Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/upload image #237

Merged
merged 13 commits into from
Jan 6, 2025
Merged

Refactor/upload image #237

merged 13 commits into from
Jan 6, 2025

Conversation

CLOUDoort
Copy link
Contributor

@CLOUDoort CLOUDoort commented Dec 31, 2024

๐Ÿ’ก ์ž‘์—… ๋‚ด์šฉ

  • upload image progress circle ๊ตฌํ˜„
  • pointer ์ด๋ฒคํŠธ ๊ธฐ๋ฐ˜์˜ drag and drop ๊ตฌํ˜„
  • web worker ์ด์šฉํ•˜์—ฌ ์ด๋ฏธ์ง€ ์••์ถ• ์†๋„ ์ตœ์ ํ™”
  • CDN path๋ฅผ preconnect ๋กœ ์—ฐ๊ฒฐ
  • lazy loading ๋ฐ fetchpriority ์ ์šฉ
  • ํ™”๋ฉด์— ๋งž๊ฒŒ ๋ฆฌ์‚ฌ์ด์ง• ์ ์šฉ

๐Ÿ’ก ์ž์„ธํ•œ ์„ค๋ช…

  • progress circle ๊ตฌํ˜„ํ•˜์—ฌ ์—…๋กœ๋“œ ์ง„ํ–‰ ์ƒํƒœ๋ฅผ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋Š” UI ์ œ๊ณต
  • ์›น ๋ฐ ๋ชจ๋ฐ”์ผ ๋ธŒ๋ผ์šฐ์ €๋ฅผ ๋ชจ๋‘ ์ง€์›ํ•˜๋Š” pointer ์ด๋ฒคํŠธ ๊ธฐ๋ฐ˜์˜ drag and drop
  • web worker๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ๋ธŒ๋ผ์šฐ์ € ๋‚ด ๋ณ„๋„์˜ ์Šค๋ ˆ๋“œ์—์„œ ์••์ถ• ๋ฐ ํฌ๋ฉง ๋ณ€ํ™˜ ์ ์šฉ

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ์ „๋žต์— ๋งž๋Š” ๋ธŒ๋žœ์น˜์— PR์„ ์˜ฌ๋ฆฌ๊ณ  ์žˆ๋‚˜์š”? (master/main์ด ์•„๋‹™๋‹ˆ๋‹ค.)
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels, Projects๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

closes #149

@CLOUDoort CLOUDoort added โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—… labels Dec 31, 2024
@CLOUDoort CLOUDoort self-assigned this Dec 31, 2024
Copy link
Contributor

@aquaman122 aquaman122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnd kit ์‚ฌ์šฉํ•ด์„œ drag and drop ๊ตฌํ˜„
worker๋กœ ์ด๋ฏธ์ง€ ์ตœ์ ํ™” ํ•˜์‹  ์ž‘์—… ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค๐Ÿ‘

<CarouselItem className='flex items-center justify-center' key={img.imageId}>
<img src={img.imageUrl} className='h-[26.36rem] object-contain w-full' alt={`${auctionName}${img.imageId}`} />
<img src={`${img.imageUrl}?h=840`} alt={`${auctionName}${img.imageId}`} className='object-contain h-[420px]' {...{ fetchpriority: idx === 0 ? 'high' : 'low' }} loading={idx === 0 ? 'eager' : 'lazy'} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฏธ์ง€ ๋ฆฌ์‚ฌ์ด์ง• ์ด๋ ‡๊ฒŒ ์‚ฌ์šฉํ•˜๋ฉด ๋˜๋Š”๊ตฐ์š”!

@CLOUDoort CLOUDoort merged commit 62f0dbf into dev Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants